Skip to content

Drop periodics for HyperShift on OpenStack on < 4.23 - #81208

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
shiftstack:drop-hcp-openstack-periodics
Jun 29, 2026
Merged

Drop periodics for HyperShift on OpenStack on < 4.23#81208
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
shiftstack:drop-hcp-openstack-periodics

Conversation

@stephenfin

@stephenfin stephenfin commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Commit 85bbd08 (#80481) dropped the presubmits but missed the periodics. Correct this.

Summary by CodeRabbit

Removed the OpenStack HyperShift periodic jobs for OpenShift releases 4.18 through 4.22. Practically, this stops CI from generating and running the scheduled HyperShift-on-OpenStack periodics that were already intended to be dropped in earlier presubmit cleanup, including the OpenStack E2E, NFV, conformance, and CSI-related variants.

The affected release configs were also cleaned up to remove now-unused OpenStack test image references tied to those jobs.

Commit 85bbd08 (openshift#80481) dropped the
presubmits but missed the periodics. Correct this.

Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
@coderabbitai

coderabbitai Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 960344e8-f2e5-4bb9-b6b2-a9494db7a702

📥 Commits

Reviewing files that changed from the base of the PR and between 250ea6e and 9d85299.

⛔ Files ignored due to path filters (5)
  • ci-operator/jobs/openshift/hypershift/openshift-hypershift-release-4.18-periodics.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/hypershift/openshift-hypershift-release-4.19-periodics.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/hypershift/openshift-hypershift-release-4.20-periodics.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/hypershift/openshift-hypershift-release-4.21-periodics.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/hypershift/openshift-hypershift-release-4.22-periodics.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (5)
  • ci-operator/config/openshift/hypershift/openshift-hypershift-release-4.18__periodics.yaml
  • ci-operator/config/openshift/hypershift/openshift-hypershift-release-4.19__periodics.yaml
  • ci-operator/config/openshift/hypershift/openshift-hypershift-release-4.20__periodics.yaml
  • ci-operator/config/openshift/hypershift/openshift-hypershift-release-4.21__periodics.yaml
  • ci-operator/config/openshift/hypershift/openshift-hypershift-release-4.22__periodics.yaml
💤 Files with no reviewable changes (5)
  • ci-operator/config/openshift/hypershift/openshift-hypershift-release-4.19__periodics.yaml
  • ci-operator/config/openshift/hypershift/openshift-hypershift-release-4.21__periodics.yaml
  • ci-operator/config/openshift/hypershift/openshift-hypershift-release-4.18__periodics.yaml
  • ci-operator/config/openshift/hypershift/openshift-hypershift-release-4.20__periodics.yaml
  • ci-operator/config/openshift/hypershift/openshift-hypershift-release-4.22__periodics.yaml

Walkthrough

Removes OpenStack-related base_images entries (manila-csi-driver-operator-test, openstack-cinder-csi-driver-operator-test, openstack-installer) and all associated OpenStack AWS periodic e2e test job definitions from HyperShift periodic configs for releases 4.18 through 4.22.

Changes

OpenStack periodic test removal (releases 4.18–4.22)

Layer / File(s) Summary
Remove OpenStack base_images entries
ci-operator/config/openshift/hypershift/openshift-hypershift-release-4.18__periodics.yaml, ...4.19__periodics.yaml, ...4.20__periodics.yaml, ...4.21__periodics.yaml, ...4.22__periodics.yaml
Deletes manila-csi-driver-operator-test, openstack-cinder-csi-driver-operator-test, and openstack-installer from base_images across all five release configs.
Remove OpenStack periodic test jobs
ci-operator/config/openshift/hypershift/openshift-hypershift-release-4.18__periodics.yaml, ...4.19__periodics.yaml, ...4.20__periodics.yaml, ...4.21__periodics.yaml, ...4.22__periodics.yaml
Removes e2e-openstack-aws, e2e-openstack-aws-nfv, e2e-openstack-aws-conformance, e2e-openstack-aws-csi-cinder, e2e-openstack-aws-csi-manila, and e2e-openstack-nested-conformance periodic test entries from all five release configs.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the change: it removes HyperShift OpenStack periodic jobs for releases earlier than 4.23.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed Only periodic YAML job entries were removed/retained; no Ginkgo test titles were added or changed, and remaining names are static.
Test Structure And Quality ✅ Passed PASS — The PR only changes periodic YAML configs for HyperShift OpenStack; no Ginkgo test code was added or modified, so this check is not applicable.
Microshift Test Compatibility ✅ Passed PR only removes periodic YAML entries; no new Ginkgo tests or test code were added, so MicroShift compatibility concerns don’t apply.
Single Node Openshift (Sno) Test Compatibility ✅ Passed No new Ginkgo e2e tests were added; this PR only removes periodic YAML jobs, so the SNO compatibility check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed Only ci-operator periodic YAMLs were changed; no deployment manifests, operators, or scheduling constraints were added.
Ote Binary Stdout Contract ✅ Passed Only ci-operator YAML/config generation files changed; no OTE binary or process-level stdout code was touched.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed No new Ginkgo e2e tests were added; the HyperShift changes only delete periodic job YAML entries, and the other YAML edits only tweak existing commands.
No-Weak-Crypto ✅ Passed Changed files are YAML periodic configs only; scans found no MD5/SHA1/DES/RC4/ECB/custom crypto or secret comparisons.
Container-Privileges ✅ Passed PASS: The changed periodic YAMLs only remove OpenStack jobs/base images; no added privileged:true, hostPID/Network/IPC, allowPrivilegeEscalation, or SYS_ADMIN settings were found.
No-Sensitive-Data-In-Logs ✅ Passed Changed files are periodic YAML configs only; no log statements or exposed secrets/tokens/PII were added. The only sensitive-looking strings are kubeconfig paths.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from enxebre and jparrill June 29, 2026 13:11

@mandre mandre left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@stephenfin: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-hypershift-release-4.20-periodics-e2e-aws-ovn-proxy-conformance N/A periodic Ci-operator config changed
periodic-ci-openshift-hypershift-release-4.20-periodics-mce-e2e-agent-connected-ovn-ipv4-metal-conformance N/A periodic Ci-operator config changed
periodic-ci-openshift-hypershift-release-4.20-periodics-mce-e2e-aws-ovn-conformance N/A periodic Ci-operator config changed
periodic-ci-openshift-hypershift-release-4.18-periodics-e2e-aws-ovn N/A periodic Ci-operator config changed
periodic-ci-openshift-hypershift-release-4.18-periodics-mce-e2e-agent-disconnected-ovn-dualstack-metal-conformance N/A periodic Ci-operator config changed
periodic-ci-openshift-hypershift-release-4.21-periodics-e2e-aws-conformance-cilium-private N/A periodic Ci-operator config changed
periodic-ci-openshift-hypershift-release-4.22-periodics-mce-e2e-kubevirt-metal-ovn-disconnected N/A periodic Ci-operator config changed
periodic-ci-openshift-hypershift-release-4.21-periodics-e2e-aws-ovn-conformance N/A periodic Ci-operator config changed
periodic-ci-openshift-hypershift-release-4.22-periodics-mce-e2e-aws-critical N/A periodic Ci-operator config changed
periodic-ci-openshift-hypershift-release-4.21-periodics-mce-e2e-ibmz-s390x-mgmt-ovn-conformance N/A periodic Ci-operator config changed
periodic-ci-openshift-hypershift-release-4.20-periodics-e2e-aws-conformance-calico N/A periodic Ci-operator config changed
periodic-ci-openshift-hypershift-release-4.21-periodics-mce-e2e-agent-disconnected-ovn-ipv6-metal-conformance N/A periodic Ci-operator config changed
periodic-ci-openshift-hypershift-release-4.22-periodics-mce-e2e-x86-power-heterogeneous-conformance N/A periodic Ci-operator config changed
periodic-ci-openshift-hypershift-release-4.18-periodics-e2e-aws-ovn-conformance N/A periodic Ci-operator config changed
periodic-ci-openshift-hypershift-release-4.19-periodics-e2e-aws-conformance-calico-private N/A periodic Ci-operator config changed
periodic-ci-openshift-hypershift-release-4.21-periodics-hcm-azure-e2e-aks-upgrade-from-zero N/A periodic Ci-operator config changed
periodic-ci-openshift-hypershift-release-4.19-periodics-mce-e2e-kubevirt-aws-ovn-gpu N/A periodic Ci-operator config changed
periodic-ci-openshift-hypershift-release-4.21-periodics-e2e-azure-aks-external-oidc-techpreview N/A periodic Ci-operator config changed
periodic-ci-openshift-hypershift-release-4.19-periodics-mce-e2e-agent-connected-calico-ipv4-metal-conformance N/A periodic Ci-operator config changed
periodic-ci-openshift-hypershift-release-4.19-periodics-hcm-e2e-aws N/A periodic Ci-operator config changed
periodic-ci-openshift-hypershift-release-4.22-periodics-mce-e2e-agent-connected-ovn-dualstack-metal-conformance N/A periodic Ci-operator config changed
periodic-ci-openshift-hypershift-release-4.20-periodics-mce-e2e-agent-connected-ovn-ipv4-metal-backuprestore N/A periodic Ci-operator config changed
periodic-ci-openshift-hypershift-release-4.18-periodics-mce-e2e-agent-connected-ovn-ipv4-metal-backuprestore N/A periodic Ci-operator config changed
periodic-ci-openshift-hypershift-release-4.18-periodics-mce-e2e-agent-connected-ovn-ipv4-manual-conformance N/A periodic Ci-operator config changed
periodic-ci-openshift-hypershift-release-4.19-periodics-mce-e2e-agent-connected-ovn-ipv4-metal-compact-conformance N/A periodic Ci-operator config changed

A total of 240 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 29, 2026
@stephenfin

Copy link
Copy Markdown
Contributor Author

/pj-rehearse ack

This is pure job removal

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@stephenfin: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jun 29, 2026
@openshift-ci

openshift-ci Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

@stephenfin: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@csrwng

csrwng commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci

openshift-ci Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csrwng, mandre, stephenfin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 29, 2026
@openshift-merge-bot
openshift-merge-bot Bot merged commit fdb3522 into openshift:main Jun 29, 2026
16 checks passed
@openshift-merge-bot
openshift-merge-bot Bot deleted the drop-hcp-openstack-periodics branch June 29, 2026 13:55
krisnababu pushed a commit to oharan2/release that referenced this pull request Jul 3, 2026
Commit 85bbd08 (openshift#80481) dropped the
presubmits but missed the periodics. Correct this.

Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
andrej1991 pushed a commit to andrej1991/release that referenced this pull request Jul 6, 2026
Commit 85bbd08 (openshift#80481) dropped the
presubmits but missed the periodics. Correct this.

Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
TimurMP pushed a commit to TimurMP/release that referenced this pull request Jul 8, 2026
Commit 85bbd08 (openshift#80481) dropped the
presubmits but missed the periodics. Correct this.

Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
SachinNinganure pushed a commit to SachinNinganure/release that referenced this pull request Jul 20, 2026
Commit 85bbd08 (openshift#80481) dropped the
presubmits but missed the periodics. Correct this.

Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
amogh-redhat pushed a commit to amogh-redhat/release that referenced this pull request Aug 5, 2026
Commit 85bbd08 (openshift#80481) dropped the
presubmits but missed the periodics. Correct this.

Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
TimurMP pushed a commit to TimurMP/release that referenced this pull request Sep 5, 2026
Commit 85bbd08 (openshift#80481) dropped the
presubmits but missed the periodics. Correct this.

Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants